-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(paths): trim leading and trailing whitespaces for file system paths #162
Conversation
@mahadzaryab1 How did you end up testing your changes on windows? |
@kehoecj I ran the code on a Windows 11 VM and I can reproduce the error in v.1.6.0. It seems like in v.1.7.0, adding a trailing whitespace in front will return a v.1.6.0
v.1.7.0
Changes from this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution and bugfix @mahadzaryab1 !
…hs (Boeing#162) * Remove Leading And Trailing Whitespaces For Paths * Add Test For Leading And Trailing Whitespaces * Add More Test Cases For Whitespaces In Middle of Path
…hs (Boeing#162) * Remove Leading And Trailing Whitespaces For Paths * Add Test For Leading And Trailing Whitespaces * Add More Test Cases For Whitespaces In Middle of Path
Remove all leading and trailing whitespaces when searching the file system for a path. This PR fixes #158.