Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

47 page for all events #50

Merged
merged 3 commits into from
Jan 31, 2024
Merged

47 page for all events #50

merged 3 commits into from
Jan 31, 2024

Conversation

Eric-Fithian
Copy link
Collaborator

closes #47

still need to make it a clickable element to take to events page but other than that everything is working.

@Eric-Fithian Eric-Fithian requested a review from nh602 January 26, 2024 20:12
@Eric-Fithian Eric-Fithian linked an issue Jan 26, 2024 that may be closed by this pull request
Page for all events #47
Closed
nh602
nh602 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@nh602 nh602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out your branch and it looks good to me. Confirmed that the page renders on my machine. When the individual event pages are finished we will need to link the events on this page to their individual pages. Merging.

@nh602 nh602 merged commit c118096 into main Jan 31, 2024
2 checks passed
@nh602 nh602 deleted the 47-page-for-all-events branch January 31, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh602 nh602 nh602 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page for all events
2 participants
@Eric-Fithian @nh602