Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finished admin eventrequests, violations routes #35

Merged
merged 4 commits into from
Jan 31, 2024
Merged

finished admin eventrequests, violations routes #35

merged 4 commits into from
Jan 31, 2024

Conversation

Eric-Fithian
Copy link
Collaborator

No description provided.

@Eric-Fithian Eric-Fithian linked an issue Nov 28, 2023 that may be closed by this pull request
Admin control backend routes #34
Closed
6 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2023
View reviewed changes
backend/routes/AdminRouter.js Fixed Show fixed Hide fixed
backend/routes/AdminRouter.js Fixed Show fixed Hide fixed
backend/routes/AdminRouter.js Fixed Show fixed Hide fixed
backend/routes/AdminRouter.js Fixed Show fixed Hide fixed
backend/routes/AdminRouter.js Fixed Show fixed Hide fixed
backend/routes/AdminRouter.js Fixed Show fixed Hide fixed
backend/routes/AdminRouter.js Fixed Show fixed Hide fixed
@nh602 nh602 merged commit f8aec50 into main Jan 31, 2024
1 check passed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2024
View reviewed changes
backend/routes/AdminRouter.js
const router = express.Router();
const sendSuccessResponse = require('../middleware/successResponse');

router.get('/events/requests/:eventId', verify('admin'), getEventRequests, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
This route handler performs
authorization
Loading
, but is not rate-limited.
backend/routes/AdminRouter.js
const router = express.Router();
const sendSuccessResponse = require('../middleware/successResponse');

router.get('/events/requests/:eventId', verify('admin'), getEventRequests, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
backend/routes/AdminRouter.js

router.get('/events/requests/:eventId', verify('admin'), getEventRequests, sendSuccessResponse);

router.get('/events/requests', verify('admin'), getAllEventRequests, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
This route handler performs
authorization
Loading
, but is not rate-limited.
This route handler performs authorization, but is not rate-limited.
This route handler performs authorization, but is not rate-limited.
backend/routes/AdminRouter.js

router.get('/events/requests/:eventId', verify('admin'), getEventRequests, sendSuccessResponse);

router.get('/events/requests', verify('admin'), getAllEventRequests, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
backend/routes/AdminRouter.js

router.get('/events/requests', verify('admin'), getAllEventRequests, sendSuccessResponse);

router.get('/violations/:vendorId', verify('admin'), getViolations, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
This route handler performs
authorization
Loading
, but is not rate-limited.
backend/routes/AdminRouter.js

router.get('/violations', verify('admin'), getAllViolations, sendSuccessResponse);

router.put('events/requests/:requestId', verify('admin'), processEventRequest, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
backend/routes/AdminRouter.js

router.put('events/requests/:requestId', verify('admin'), processEventRequest, sendSuccessResponse);

router.post('/violations/:vendorId', verify('admin'), createVendorViolation, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
This route handler performs
authorization
Loading
, but is not rate-limited.
backend/routes/AdminRouter.js

router.put('events/requests/:requestId', verify('admin'), processEventRequest, sendSuccessResponse);

router.post('/violations/:vendorId', verify('admin'), createVendorViolation, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
backend/routes/AdminRouter.js

router.post('/violations/:vendorId', verify('admin'), createVendorViolation, sendSuccessResponse);

router.delete('/violations/:violationId', verify('admin'), deleteVendorViolation, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
This route handler performs
authorization
Loading
, but is not rate-limited.
This route handler performs authorization, but is not rate-limited.
This route handler performs authorization, but is not rate-limited.
backend/routes/AdminRouter.js

router.post('/violations/:vendorId', verify('admin'), createVendorViolation, sendSuccessResponse);

router.delete('/violations/:violationId', verify('admin'), deleteVendorViolation, sendSuccessResponse);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin control backend routes
2 participants
@Eric-Fithian @nh602