SimulationConfig: modifications as a list to preserve the order #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorblancoa
reviewed
Jul 2, 2024
jorblancoa
reviewed
Jul 2, 2024
WeinaJi
force-pushed
the
weji/modifications_list
branch
from
db218ef
to
c9b9ab1
Compare
jorblancoa
approved these changes
Jul 4, 2024
4 tasks
jorblancoa
added a commit
to BlueBrain/neurodamus
that referenced
this pull request
Aug 8, 2024
## Context This PR is to adapt the change in libsonata API (BlueBrain/libsonata#359) that the data type of `modifications from` is list for preserving the modification order. ## Scope The `parsedModifications` function in `sonata_config.py`. ## Testing Current unit test `test_sonata_config.py` and needs to wait for the libsonata change to be deployed on bb5. ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation --------- Co-authored-by: Jorge Blanco Alonso <[email protected]>
WeinaJi
added a commit
to BlueBrain/neurodamus
that referenced
this pull request
Oct 14, 2024
## Context This PR is to adapt the change in libsonata API (BlueBrain/libsonata#359) that the data type of `modifications from` is list for preserving the modification order. ## Scope The `parsedModifications` function in `sonata_config.py`. ## Testing Current unit test `test_sonata_config.py` and needs to wait for the libsonata change to be deployed on bb5. ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation --------- Co-authored-by: Jorge Blanco Alonso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPEC: BlueBrain/sonata-extension#55