Skip to content

Commit

Permalink
Update upload/download action to v4. (#369)
Browse files Browse the repository at this point in the history
* Update upload/download action to `v4`.
* Make artifact names unique.
   See https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
* Also make `matrix.os` part of the name.
  • Loading branch information
1uc authored Sep 4, 2024
1 parent 5b1c2c8 commit d8323e9
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/publish-sdist-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ jobs:
python -m cibuildwheel --output-dir dist
- name: Store wheel as artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
name: dist-wheels-${{ matrix.os }}
path: dist/*.whl

build_sdist:
Expand Down Expand Up @@ -125,9 +125,9 @@ jobs:
./ci/python_build_sdist.sh

- name: Store sdist as artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
name: dist-sdist
path: dist/*.tar.gz

upload_artifacts:
Expand All @@ -139,10 +139,11 @@ jobs:

steps:
- name: Download artifacts produced during the build_wheels and build_sdist jobs
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: dist
name: dist-*
path: dist/
merge-multiple: true

- name: Display structure of downloaded files
run: ls -R
Expand Down

0 comments on commit d8323e9

Please sign in to comment.