Fix earmuff behavior for long-running sounds #5863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the earmuffs would only affect sounds when they started, i.e. a sound started before putting on earmuffs would never get attenuated while a sound started while wearing earmuffs would be attenuated forever.
BluSunrize
approved these changes
Feb 11, 2024
|
Followup question: Is this something we should have considered for 1.20.1? |
It will "just work" with multiple mods, and that's essentially why it isn't on 20.1: this clean and compatible implementation only works with MixinExtras, which isn't provided by NeoForge on 20.1. I can try to put something together, but it will probably be much more complex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Disord starting here: The previous implementation only applied attenuation when starting the sound, so long-running sounds did not update when earmuffs were equipped/unequipped. The new approach uses a Mixin, but can handle such sounds correctly.
Note that this PR is on 1.20.4 since for a compatible implementation we need the injectors from MixinExtras. This library is provided by NF on 1.20.4, but not on 1.20.1.