Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #325: Include Assembly Code in Manifest #330

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

bhekster-relyance
Copy link
Contributor

Issue #325 describes an issue trying to build with Python 3.12. The root cause is suggested by these error messages:

/usr/bin/ld: blosc/c-blosc/blosc/CMakeFiles/blosc_shared.dir//internal-complibs/zstd-1.5.2/decompress/huf_decompress.c.o: in function HUF_decompress4X1_usingDTable_internal_bmi2_asm': huf_decompress.c:(.text+0x2c2b): undefined reference to HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop'
/usr/bin/ld: blosc/c-blosc/blosc/CMakeFiles/blosc_shared.dir//internal-complibs/zstd-1.5.2/decompress/huf_decompress.c.o: in function HUF_decompress4X2_usingDTable_internal_bmi2_asm': huf_decompress.c:(.text+0x6a58): undefined reference to HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop'
/usr/bin/ld: blosc/c-blosc/blosc/libblosc.so.1.21.3: hidden symbol `HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop' isn't defined
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status

The “hidden symbol” message is a red herring. The real problem is that these symbols are defined in an Assembly language source file blosc/c-blosc/internal-complibs/zstd-1.5.2/decompress/huf_decompress_amd64.S which isn't being packaged in.

This Pull Request updates MANIFEST.in to recursively include all .S files.

@bhekster-relyance bhekster-relyance changed the title Fixes #325: Include Assembly code in manifest Fixes #325: Include Assembly Code in Manifest Jun 16, 2024
@FrancescAlted
Copy link
Member

LGTM. Thanks @bhekster-relyance !

@FrancescAlted FrancescAlted merged commit 5eab221 into Blosc:main Jun 24, 2024
3 of 16 checks passed
@bhekster-relyance bhekster-relyance deleted the fix-issue-325 branch June 25, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants