Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

halfagg: Remove fixed limit #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

real-or-random
Copy link
Collaborator

This is one way to deal with the limit. My thinking is that we shouldn't be responsible for the limit.

The drawback of this approach is that it removes some tests. The rust spec is still correct in the sense that you can't possibly have two Seqs whose combined size is larger than usize::MAX because you won't have enough memory. But that's rather implicit, and it may not be true for implementations using other data types, or in other languages etc. Implementations that want to enforce a limit will have to figure out how to do it, because the spec won't help them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant