Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to rust examples in github action #530

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

nepet
Copy link
Collaborator

@nepet nepet commented Oct 18, 2024

Fixes the path to the rust examples in the github action.

Signed-off-by: Peter Neuroth <[email protected]>
@nepet
Copy link
Collaborator Author

nepet commented Oct 18, 2024

Please wait before merging this, I am going to add some CI improvements as well. Currently we are blind if the docs can be built without an error on PRs. We should change that to a more robust system where we

  • build docs on PR if we changed something in docs/ or examples
  • reuse build workflow and deploy docs on merge to main if we changed something in docs/ or examples

@nepet nepet self-assigned this Oct 18, 2024
@cdecker
Copy link
Collaborator

cdecker commented Oct 21, 2024

Let's open a new issue for this, we need to get the docs back to working order, and what you're proposing is new functionality anyway.

@cdecker cdecker merged commit d1d42a6 into main Oct 21, 2024
13 checks passed
@cdecker cdecker deleted the 2442-fix-docs-ci branch October 21, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants