Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vls: Upgrade to the v0.12 release of VLS #504

Merged
merged 3 commits into from
Aug 28, 2024
Merged

vls: Upgrade to the v0.12 release of VLS #504

merged 3 commits into from
Aug 28, 2024

Conversation

cdecker
Copy link
Collaborator

@cdecker cdecker commented Aug 27, 2024

No description provided.

@cdecker cdecker requested a review from nepet August 27, 2024 14:17
@cdecker
Copy link
Collaborator Author

cdecker commented Aug 27, 2024

@roeierez sadly, this new version does not resolve the issue I was facing earlier today, but it still addresses some issues, and we should likely just keep as much in sync with VLS as we can, so let's apply this change.

The desync issue that I'm seeing on my host (and nowhere esle for now), is a complaint about wanting to sign state number 22319 when it should be 22324. I'll dig further into how we got into this situation.

Copy link
Collaborator

@nepet nepet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VLS confuses me a bit in a way that the handle() function of different handler types return different results but afaict all changes are correct.

ack 899a9ba

@cdecker cdecker enabled auto-merge (rebase) August 28, 2024 13:24
@cdecker cdecker merged commit c4729a9 into main Aug 28, 2024
13 checks passed
@cdecker cdecker deleted the 202408-vls012 branch August 28, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants