Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .resources dir to all crates in workspace #501

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

nepet
Copy link
Collaborator

@nepet nepet commented Aug 19, 2024

In order to publish the crates individually, we need to attach our resources to them. Currently this is mostly the proto files and the tls (nobody) certificates where needed.

This PR also adds some improvements to the Makefiles (also the root Makefile) for ease of use.

@nepet nepet marked this pull request as ready for review August 19, 2024 15:15
In order to publish the crates individually, we need to attach our
resources to them. Currently this is mostly the proto files and the
tls (nobody) certificates.

This commit also adds `sync-files` to the root Makefile for ease of use.

Signed-off-by: Peter Neuroth <[email protected]>
Adds some rust (cargo) convenience targets to the Makefiles, this allows
to run clippy on `check` targets. This may help us to address clippy
hints in the future.

Signed-off-by: Peter Neuroth <[email protected]>
@nepet nepet requested a review from cdecker August 27, 2024 11:38
@cdecker cdecker merged commit 5d57a35 into main Aug 27, 2024
13 checks passed
@cdecker cdecker deleted the 2434-add-resource-dirs branch August 27, 2024 11:40
@cdecker
Copy link
Collaborator

cdecker commented Aug 27, 2024

ACK 5725a73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants