Fix CI error: "AttributeError: channels" #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nepet
force-pushed
the
check-ci-channel-failures
branch
2 times, most recently
from
043847c to
4118ac3
Compare
The channels array returned by the rpc call `listpeers` is optional and has been deprecated with v23.02 and will be removed after v24.02 Signed-off-by: Peter Neuroth <[email protected]>
Replace list_peers().channel (which is optional) with list_peer_channels(). Signed-off-by: Peter Neuroth <[email protected]>
nepet
force-pushed
the
check-ci-channel-failures
branch
from
4118ac3 to
6af1e57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 open PRs that produce the same error
AttributeError: channelson the following tests:It seems that the optional
channelsarray returned bylistpeersis not reliable anymore. This PR replaces thelistpeerscalls bylistpeerchannelswhich will return achannelsarray.