Add mypy-protobuf to the dev dependencies #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We added mypy-protobuf as a dependency a while ago. This commit adds the package to the developer dependencies to allow for a build from the poetry shell. - Some improvements to the Makefile so that we can run it from the top dir as well as from withing the gl-client-py dir. Signed-off-by: Peter Neuroth <[email protected]>
|
ACK 6f15286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following two changes:
mypy-protobufto thegl-client-pydev dependencies so that we can compile the grpc files from a poetry shell.Makefiletargetsclean-pyandpygrpcto allow them to be called from the top dir as well as from withingl-client-py