client: Added code that implements the lnurl lud06 spec. #226
Conversation
There was a problem hiding this comment.
Wow arti is huge :-) Slowly getting concerned about the binary size that we have to ship to various bindings. As promised I went through it with a really fine-toothed comb, so there are a lot of comments, but feel free to ignore them.
The mix of async and blocking is a bit strange, and some operations, such as initializing Tor circuits, could be deferred a bit so we don't pay the costs even though we don't use it later.
| address_filter.build()?; | ||
| config_builder.build()?; | ||
|
|
||
| let tor_client = TorClient::create_bootstrapped(config_builder.build().unwrap()).await?; |
There was a problem hiding this comment.
| let tor_client = TorClient::create_bootstrapped(config_builder.build().unwrap()).await?; | |
| let tor_client = TorClient::create_bootstrapped(config_builder.build()?).await?; |
There was a problem hiding this comment.
Notice too that create_bootstrapped is actually going out and establishing Tor circuits, which can take considerable time. If we then end up not using that circuit all of that work is wasted. It'd likely be a better idea to keep the builder around, and defer bootstrapping to when we know we need the circuit.
cdecker
changed the title
| fn convert_to_async_return_value<T: Send + 'static>( | ||
| value: T, | ||
| ) -> Pin<Box<dyn std::future::Future<Output = T> + Send>> { | ||
| let ready_future: Ready<_> = future::ready(value); | ||
| Pin::new(Box::new(ready_future)) as Pin<Box<dyn std::future::Future<Output = T> + Send>> | ||
| } |
There was a problem hiding this comment.
Very clever, definitely something I need to remember 👍
Randy808
force-pushed
the
lnurl-lud06
branch
3 times, most recently
from
41fbf1d
to
4ce559f
Compare
Randy808
force-pushed
the
lnurl-lud06
branch
3 times, most recently
from
6838ad2
to
e631b19
Compare
|
The build is failing after rebasing. I'm still looking into what it could be |
libs/gl-client/Cargo.toml
Outdated
| log = "^0.4" | ||
| pin-project = "*" | ||
| prost = "0.11" | ||
| reqwest = {version="0.11.18", features=["json"]} |
There was a problem hiding this comment.
This is implicitly pulling in openssl-sys which depends on the openssl headers. We already use rustls through tonic, so we likely want to use the rustls-tls-native-roots feature.
…nc to remove the tokio runtime.
…method parameter.
… methods needed to manually resolve an lnurl to an invoice.
| @@ -679,7 +679,6 @@ mod tests { | |||
| signer_state: vec![], | |||
| requests: Vec::new(), | |||
| }, | |||
| vec![], | |||
There was a problem hiding this comment.
Removing this line since it's preventing the tests from building.
The method signature change was causing it to fail:
https://github.com/Blockstream/greenlight/pull/227/files#diff-8d5abc718d7a05d6432918246fcf5f9919681ca385b057f72a2117e9878e1932R284
No description provided.