test(erc20.sol): testing for events and completed testing #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
princeibs
requested changes
Sep 21, 2024
| vm.expectRevert(ERC20.InvalidRecipient.selector); | ||
| vm.prank(ownerAddress); | ||
| erc20Contract.transfer(address(0), 500); | ||
| assertEq(erc20Contract.balanceOf(ownerAddress), 1000, "Amount supposed to be 500"); |
There was a problem hiding this comment.
Change error message from "Amount supposed to be 500" to "Amount supposed to be 1000"
| assertEq(erc20Contract.balanceOf(ownerAddress), 1000, "Amount supposed to be 1000"); | ||
| vm.expectEmit(true, true, false, true); | ||
| emit Transfer(ownerAddress, recipient, 500); | ||
| vm.prank(ownerAddress); |
There was a problem hiding this comment.
No need to prank again since prank from line 69 is still effective
| assertEq(erc20Contract.balanceOf(recipient), 0, "Amount supposed to be 0"); | ||
| assertEq(erc20Contract.balanceOf(ownerAddress), 0, "Amount supposed to be 0"); | ||
| vm.prank(ownerAddress); | ||
| erc20Contract.mint(ownerAddress, 1000); |
There was a problem hiding this comment.
use variables instead of literal values. e.g:
uint mintAmount = 1000;
uint tranferAmount = 500;
| } | ||
|
|
||
| function test_changeOwner() public { | ||
| address newowner = address(0x2938); |
There was a problem hiding this comment.
Check current value of ownerAddress before calling changeOwner()
| //check if they were minted succesfully | ||
| assertEq(bwcErc20TokenContract.balanceOf(callingAddress), mintConst, "Balance is supposed to be 1000"); | ||
| assertEq(receiptTokenContract.balanceOf(stakingContractAddress), mintConst, "Balance is supposed to be 1000"); | ||
|
|
There was a problem hiding this comment.
Also check for the balance change of reward tokens in the contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description: Testing ERC20 Contract Events
Summary
This PR introduces a series of tests to validate the ERC20 contract's behavior, specifically focusing on key events and functions, such as transfers, approvals, ownership changes, and burn functionality.
Tests Covered
Event Emissions:
Functionality Tests:
Changes Made
testRevert_transferRevertedIfZeroAddressto verify that transfers from the zero address are reverted.test_Burnto test the token burn functionality.testRevert_changeOwnerShouldRevertIfUnauthorizedto ensure unauthorized ownership changes are reverted.test_changeOwnerto test successful ownership changes.test_transferto validate the transfer function.Checklist