Allow invalid bip39 mnemonic, add cosigner #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entials when cloning the repo.
gorazdko
changed the title
|
linking test report of my own I did with Guardian and GC: https://gist.github.com/gorazdko/0c3f04f50962235e0439be6398e83393 ready for review |
|
tACK |
|
@gorazdko, ready for me to merge? |
ChristopherA
approved these changes
Apr 6, 2021
|
@ChristopherA please do merge. There are also 4 PRs in bc-keytool-cli waiting to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Supercedes #58
The name chosen for the procedure is
BIP39 sentence completion. The name and word usage is not set in stone and will be updated according to theresolution of BlockchainCommons/Gordian-Developer-Community#27
The guide can be seen rendered here and uses a reference to Rudefox ShowMyWork lookup tables:
https://github.com/gorazdko/bc-lethekit/blob/dd3d47e7704e5856d3327c0e16a97063b40f3a57/seedtool/doc/bip39_sentence_completion.md
Added cosigner
Also improvements in documentation:
Next stepsso that user can follow them more easilyStatus
ready for review