feat: update L1 origin block hash handling and add full L1 origin block hash field #631
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 88.61% 88.61%
=======================================
Files 159 159
Lines 10664 10665 +1
Branches 1195 1195
=======================================
+ Hits 9450 9451 +1
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
332.27 KB (🔴 +86.65 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Pages Added
The following pages were added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/block_neighbor |
251 B |
332.51 KB | 95.00% |
/stats |
348 KB |
680.27 KB | 194.36% |
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/ |
353.07 KB |
685.34 KB | 195.81% (🟢 -4.65%) |
/address/[address] |
28.54 KB |
360.81 KB | 103.09% (🟢 -4.34%) |
/blob/[hash] |
29.22 KB |
361.49 KB | 103.28% (🟢 -3.77%) |
/blobs |
79.05 KB |
411.32 KB | 117.52% (🟡 +13.21%) |
/block/[id] |
14.9 KB |
347.17 KB | 99.19% (🟢 -3.99%) |
/blocks |
76.75 KB |
409.02 KB | 116.86% (🟡 +13.20%) |
/tx/[hash] |
17.23 KB |
349.5 KB | 99.86% (🟡 +1.13%) |
/txs |
76.25 KB |
408.52 KB | 116.72% (🟡 +11.19%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
There was a problem hiding this comment.
Left a comment.
Additionally, the autocompleteBlockHash function is not working correctly.
We are filtering hashes that start with the partialHash here. However, this condition will never hold because the partial hash is not prefixed with 0x, whereas the block hashes are.
| } | ||
| > | ||
| {"0x" + decodedData.l1OriginBlockHash} | ||
| {"0x" + decodedData.fullL1OriginBlockHash} |
There was a problem hiding this comment.
Let's extract this to a constant?
|
Another request: Can we move the |
|
A few more changes, @luis-herasme, we should make to the UI for the decoded fields based on new information we’ve learned about the blobs: |
| {"0x" + decodedData.parentL2BlockHash + "..."} | ||
| </div> | ||
| ), | ||
| value: "0x" + decodedData.parentL2BlockHash + "...", |
There was a problem hiding this comment.
I've found Ox several times repeated as a raw string. I would create a const for it
Checklist
Description
If the full block hash cannot be found, this change avoids adding a link to the block hash field, as the URL would be incorrect.
Related Issue
#630