Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add category column to blob and transaction tables #623

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

xFJA
Copy link
Collaborator

@xFJA xFJA commented Nov 8, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

A category column has been added to blob and transactions tables

Related Issue

Closes #595

Screenshots

image

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 8:48am
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 8:48am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 8:48am
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 8:48am
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 8:48am
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 8:48am

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 82ae387

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@blobscan/api Minor
@blobscan/web Minor
@blobscan/rest-api-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 8, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 332.16 KB (🔴 +86.54 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 332.41 KB 94.97%
/stats 348 KB 680.17 KB 194.33%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 353.07 KB 685.23 KB 195.78% (🟢 -4.65%)
/address/[address] 28.54 KB 360.7 KB 103.06% (🟢 -4.34%)
/blob/[hash] 29.22 KB 361.39 KB 103.25% (🟢 -3.77%)
/blobs 79.13 KB 411.29 KB 117.51% (🟡 +13.23%)
/block/[id] 14.9 KB 347.07 KB 99.16% (🟢 -3.99%)
/blocks 76.75 KB 408.91 KB 116.83% (🟡 +13.20%)
/tx/[hash] 17.3 KB 349.46 KB 99.85% (🟡 +1.15%)
/txs 76.28 KB 408.44 KB 116.70% (🟡 +11.19%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (5272928) to head (e76a12c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   89.15%   89.14%   -0.01%     
==========================================
  Files         155      155              
  Lines       10492    10492              
  Branches     1186     1186              
==========================================
- Hits         9354     9353       -1     
- Misses       1138     1139       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Blob Gas Price" column on tx table looks cropped

image

Also, category is not being displayed on the blobs table:

image

@PJColombo
Copy link
Member

I'm also thinking it would make more sense to remove "Rollup" column and display rollup logo in the "Category" by adding it right next to the "Rollup" label.

@xFJA
Copy link
Collaborator Author

xFJA commented Nov 9, 2024

@PJColombo answer for your comments:

  • Fixed the category not displayed on blobs table
  • I've checked the Blob Gas Price column in blobs table and I cannot notice any crop. The table has a horizontal scroll for the overflowing columns. Could you check it again?
    image

@xFJA
Copy link
Collaborator Author

xFJA commented Nov 10, 2024

I'm also thinking it would make more sense to remove "Rollup" column and display rollup logo in the "Category" by adding it right next to the "Rollup" label.

Agree! Having both columns is redundant and removes width space. I have merged both columns into one with your proposal 👍

Copy link
Member

@PabloCastellano PabloCastellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add category column to transactions and blobs view tables
3 participants