Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): add tx index to BlobsOnTransactions model #584

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

PJColombo
Copy link
Member

@PJColombo PJColombo commented Sep 26, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

This PR further denormalizes the database by adding the index column from the Transaction model to the BlobsOnTransactions model.

Benefits:

  • Reduces the need for a join when fetching multiple blobs, simplifying the Prisma query and improving performance.
  • Enables easier implementation of cursor-based pagination by using a composite sequential cursor consisting of block timestamp, tx index, and blob index.

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 016295e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@blobscan/db Minor
@blobscan/api Patch
@blobscan/web Patch
@blobscan/blob-propagation-jobs-cli Patch
@blobscan/stats-aggregation-cli Patch
@blobscan/auth Patch
@blobscan/blob-propagator Patch
@blobscan/blob-storage-manager Patch
@blobscan/rollups Patch
@blobscan/syncers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 9:34am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:34am
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:34am
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:34am
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:34am
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:34am

Copy link
Contributor

github-actions bot commented Sep 26, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 283.8 KB (🟡 +38.18 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 284.04 KB 81.16%
/stats 347.54 KB 631.33 KB 180.38%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 351.83 KB 635.63 KB 181.61% (🟢 -5.00%)
/address/[address] 26.96 KB 310.76 KB 88.79% (🟢 -4.79%)
/blob/[hash] 27.63 KB 311.42 KB 88.98% (🟢 -4.23%)
/blobs 76.52 KB 360.31 KB 102.95% (🟡 +12.48%)
/block/[id] 14.31 KB 298.11 KB 85.17% (🟢 -4.15%)
/blocks 74.22 KB 358.02 KB 102.29% (🟡 +12.47%)
/tx/[hash] 16.31 KB 300.11 KB 85.75% (🟡 +0.87%)
/txs 73.72 KB 357.52 KB 102.15% (🟡 +10.46%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (bd8a4cb) to head (016295e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/db/prisma/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         153      153           
  Lines       10141    10141           
  Branches     1066     1066           
=======================================
  Hits         9084     9084           
  Misses       1057     1057           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PJColombo PJColombo merged commit 6eb69e8 into main Sep 26, 2024
13 of 14 checks passed
@PJColombo PJColombo deleted the perf/db/add-tx-index-to-blob-model branch September 26, 2024 09:40
@github-actions github-actions bot mentioned this pull request Oct 6, 2024
luis-herasme pushed a commit that referenced this pull request Oct 13, 2024
* chore: add changeset

* chore: merge changesets

* chore(db): refactor database generator

* feat(db): add tx index to  `BlobsOnTransactions` model

* feat: make tx index mandatory

* perf(api): add block timestamp and transaction index as ordering clauses when fetching blobs

* chore: add changeset

* fix(api): return tx index when fetching a single blob

* perf(db): improve tx index backfilling migration
@PJColombo PJColombo restored the perf/db/add-tx-index-to-blob-model branch October 29, 2024 11:30
@PJColombo PJColombo deleted the perf/db/add-tx-index-to-blob-model branch October 29, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant