Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add navigation arrows to blob details page #560

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Adds navigation arrows to blob details page

Related Issue

Closes #474

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 0:13am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 0:13am
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 0:13am
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 0:13am
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 0:13am
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 0:13am

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 523fcf5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 16.50485% with 86 lines in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (e7187c3) to head (523fcf5).

Files with missing lines Patch % Lines
packages/api/src/routers/blob/getBlobNeighbours.ts 14.85% 86 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   89.02%   88.30%   -0.73%     
==========================================
  Files         154      155       +1     
  Lines       10259    10362     +103     
  Branches     1143     1143              
==========================================
+ Hits         9133     9150      +17     
- Misses       1126     1212      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 332.93 KB (🔴 +87.31 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 333.18 KB 95.19%
/stats 347.54 KB 680.47 KB 194.42%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 351.81 KB 684.74 KB 195.64% (🟢 -5.01%)
/address/[address] 26.94 KB 359.87 KB 102.82% (🟢 -4.80%)
/blob/[hash] 29.05 KB 361.98 KB 103.42% (🟢 -3.82%)
/blobs 76.74 KB 409.67 KB 117.05% (🟡 +12.55%)
/block/[id] 14.33 KB 347.26 KB 99.22% (🟢 -4.15%)
/blocks 74.44 KB 407.37 KB 116.39% (🟡 +12.54%)
/tx/[hash] 16.34 KB 349.28 KB 99.79% (🟡 +0.89%)
/txs 73.94 KB 406.87 KB 116.25% (🟡 +10.53%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

PabloCastellano and others added 16 commits October 13, 2024 15:38
* ci: deploy to Vercel using git tags (like v0.1.0)

* ci: add .vercel
* feat(api): add support for enabling item counting when requesting a list of blobs, blocks, or transactions

* chore: add changeset

* test(api): remove `only` calls
* fix(api): set category filter to `ROLLUP` when the rollup filter is provided

* feat(api): create blob `getCount` procedure

* chore: add changeset

* refactor(web): use `getCount()` procedure to retrieve total amount of blobs

* chore: add changeset

* feat(api): create block `getCount` procedure

* chore: add changeset

* fix(web): align header sleketon on blobs page view

* refactor(web): use `getCount()` procedure to retrieve total amount of blocks

* refactor(api): use count logic in `getAll` block procedure

* feat(api): add transaction `getCount` procedure

* refactor(web): use `getCount()` procedure to retrieve total amount of transactions on txs page

* chore: merge changesets

* refactor(web): organize query parameters by filter and pagination usage

* test(api): remove rollup test
* chore: add changeset

* chore: merge changesets

* chore(db): refactor database generator

* feat(db): add tx index to  `BlobsOnTransactions` model

* feat: make tx index mandatory

* perf(api): add block timestamp and transaction index as ordering clauses when fetching blobs

* chore: add changeset

* fix(api): return tx index when fetching a single blob

* perf(db): improve tx index backfilling migration
* refactor(db): swap composite key columns

* perf(db): update tx indexes to use block timestamp instead of block number

* perf(db): use block number to sort results when a block number filter is provided on txs and blobs pages
* feat(db): add `category` and `rollup` to stats models

* fix(db): add missing `id` field to blob daily stats model

* chore: bump prisma deps to latest version

* chore(db): enable `typedSql` on prisma

* feat(db): add blob max fee columns to transaction stats models

* chore: add changeset

* feat(db): treat category and rollup null values as distinct

* feat(db): add total blob gas price columns

* feat(db): add address history model

* feat(dayjs): add date utily functions

* chore: add changeset

* feat: add support for category and rollup aggregations

* chore: add changeset

* test(stats-aggregation-cli): update snapshots

* fix(api): fix import issue

* style: apply suggestions from code review

Co-authored-by: Pablo Castellano <[email protected]>

* test(api): unskip tests

* refactor: rename `AddressHistory` model to `AddressCategoryInfo`

* feat: make `category` column optional on `AddressCategoryInfo` model

* feat(api): upsert lowest overall address category info

* style(stats-aggregation-cli): add comment

---------

Co-authored-by: Pablo Castellano <[email protected]>
* chore(ci): create env file in set up action

* chore(ci): add set up db action

* chore(ci): use set up db action
* test: remove `console.log`

* test: sort results to be checked by category and rollup when possible

* test(api): recreate blob storage manager on each test
… build

Ensure PostgreSQL is running and pass the database connection to the Docker build process. This is necessary for building images, as Prisma client generation now requires a live database connection.
PJColombo and others added 4 commits October 19, 2024 17:28
* fix(api): set category filter to `ROLLUP` when the rollup filter is provided

* feat(api): create blob `getCount` procedure

* chore: add changeset

* refactor(web): use `getCount()` procedure to retrieve total amount of blobs

* chore: add changeset

* feat(api): create block `getCount` procedure

* chore: add changeset

* fix(web): align header sleketon on blobs page view

* refactor(web): use `getCount()` procedure to retrieve total amount of blocks

* refactor(api): use count logic in `getAll` block procedure

* feat(api): add transaction `getCount` procedure

* refactor(web): use `getCount()` procedure to retrieve total amount of transactions on txs page

* chore: merge changesets

* refactor(web): organize query parameters by filter and pagination usage

* test(api): remove rollup test
* feat(rollups): add missing sepolia rollups

* chore: add changeset
* feat: Add PostHog integration for API request tracking

* chore: added changeset

* feat: Add posthog to trpc/api

* feat: PostHog is now optional

* chore: Remove unnecessary include in tsconfig.json

* Update .changeset/brave-pants-divide.md

Co-authored-by: Pablo Castellano <[email protected]>

* chore: Use a random UUID for the PostHog distinctId

* feat: Add posthog-js to the frontend

* refactor: Update posthog.capture to use getIP function

* chore: Rename POSTHOG_KEY to POSTHOG_ID

* docs: Added posthog .env docs

* refactor: Update PostHog host URL in environment configuration

* chore: Remove PostHog changeset

* Adds NEXT_PUBLIC_POSTHOG_ID and NEXT_PUBLIC_POSTHOG_HOST to env

---------

Co-authored-by: Pablo Castellano <[email protected]>
* fix(api): set category filter to `ROLLUP` when the rollup filter is provided

* feat(api): create blob `getCount` procedure

* chore: add changeset

* refactor(web): use `getCount()` procedure to retrieve total amount of blobs

* chore: add changeset

* feat(api): create block `getCount` procedure

* chore: add changeset

* fix(web): align header sleketon on blobs page view

* refactor(web): use `getCount()` procedure to retrieve total amount of blocks

* refactor(api): use count logic in `getAll` block procedure

* feat(api): add transaction `getCount` procedure

* refactor(web): use `getCount()` procedure to retrieve total amount of transactions on txs page

* chore: merge changesets

* refactor(web): organize query parameters by filter and pagination usage

* test(api): remove rollup test
PJColombo and others added 4 commits October 19, 2024 17:33
* fix(api): set category filter to `ROLLUP` when the rollup filter is provided

* feat(api): create blob `getCount` procedure

* chore: add changeset

* refactor(web): use `getCount()` procedure to retrieve total amount of blobs

* chore: add changeset

* feat(api): create block `getCount` procedure

* chore: add changeset

* fix(web): align header sleketon on blobs page view

* refactor(web): use `getCount()` procedure to retrieve total amount of blocks

* refactor(api): use count logic in `getAll` block procedure

* feat(api): add transaction `getCount` procedure

* refactor(web): use `getCount()` procedure to retrieve total amount of transactions on txs page

* chore: merge changesets

* refactor(web): organize query parameters by filter and pagination usage

* test(api): remove rollup test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create "Next" and "Previous" buttons for the blob details page
3 participants