Transition to using YAML for configs #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change I've wanted to do for some time.
Pros
hasattr
andgetattr
situationsCons
I've tested this impl a bunch and haven't found anything that's broken, and after checking through all changes and doing some tests I think this is 'complete'. The only thing that might change is the behavior of
Configuration.__getattr__
to not return None when something is missing (raising instead).