Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes can be made resizable #319

Closed

Conversation

Heathermcx
Copy link

Resizers can be added to a node. Dragging a resizer resizes the node.

Heathermcx and others added 2 commits May 17, 2023 11:05
Resizers can be added to a node. Dragging a resizer resizes the node.

---------

Co-authored-by: Matt Swain <matthew.swain@wisetechglobal.com>
@Heathermcx Heathermcx mentioned this pull request Jun 2, 2023
@zHaytam
Copy link
Collaborator

zHaytam commented Jun 2, 2023

Hello,

First of all thanks a lot for the PR, it's a great amount of work!

Thing is, I have created the Controls feature for this. Since Controls are meant to be "addons" to models (nodes/links), Resizing feature fits perfectly. Controls have widgets too and can be drawn, so all in all it's really made for this type of stuff.

I don't see a Resizer a model because it doesn't really hold any data/information, it's just a thing that you use to change the size of a model, which is purely UI based and I doubt you would consider saving this in the backend no?

What do you think? Sorry if this feels like I'm disregarding your work.

@zHaytam zHaytam closed this Sep 29, 2023
@Heathermcx
Copy link
Author

Hi, sorry for the delay in reply. Thank you for the feedback! It makes sense. I have implemented resizing using Controls. PR #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants