add examples #16
Closed
add examples #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @brianjking Thanks for this PR! |
Blaizzy
requested changes
May 5, 2024
Comment on lines
+22
to
+33
|
|
||
| * Idefics 2 w/ Local Path | ||
|
|
||
| ```sh | ||
| python -m mlx_vlm.generate --model mlx-community/idefics2-8b-4bit --max-tokens 1000 --temp 0.0 --prompt "Describe this image" --image /path/to/file.png | ||
| ``` | ||
|
|
||
| * Idefics 2 w/ Local Path | ||
|
|
||
| ```sh | ||
| python -m mlx_vlm.generate --model mlx-community/idefics2-8b-4bit --max-tokens 1000 --temp 0.0 --prompt "Is this a logo?" --image https://pypi.org/static/images/logo-small.8998e9d1.svg |
There was a problem hiding this comment.
I really like the direction!
How about we compress these examples.
For instance, hve a single example and then explain that what we can pass to the --image and --model. Since both are quite similar
There was a problem hiding this comment.
Also, there are some changes you might want to check in #17
|
I'm closing this PR for now. Let me know when you want to pick it up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.