Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open tokenizer.json within context manager #129

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Open tokenizer.json within context manager #129

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e0f56a
Open tokenizer.json within context manager
neilmehta24 Nov 27, 2024
cfcdb67
Update mlx_vlm/tokenizer_utils.py
neilmehta24 Nov 27, 2024
3b62a23
Add import statement and run pre-commit
neilmehta24 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mlx_vlm/tokenizer_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,8 @@ def load_tokenizer(model_path, return_tokenizer=True, tokenizer_config_extra={})

tokenizer_file = model_path / "tokenizer.json"
if tokenizer_file.exists():
tokenizer_content = json.load(tokenizer_file.open())
with open(tokenizer_file, "r") as f:
tokenizer_content = json.load(f)
neilmehta24 marked this conversation as resolved.
Show resolved Hide resolved
if "decoder" in tokenizer_content:
if _is_spm_decoder(tokenizer_content["decoder"]):
detokenizer_class = SPMStreamingDetokenizer
Expand Down