Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statics): enabled bulk withdrawal feature #5256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krupanand-bitgo
Copy link
Contributor

@krupanand-bitgo krupanand-bitgo commented Dec 12, 2024

Enabled Bulk withdrawal feature in testnet and production for assets mentioned in below ticket.

Ticket: WIN-3962

@krupanand-bitgo krupanand-bitgo marked this pull request as ready for review December 12, 2024 08:41
@krupanand-bitgo krupanand-bitgo requested review from a team as code owners December 12, 2024 08:41
@krupanand-bitgo krupanand-bitgo changed the title feat(statics): enabled bulk withdrawal feature feat(statics): enabled bulk withdrawal feature testnet Dec 12, 2024
Copy link
Contributor

@margueriteblair margueriteblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be fixed

@krupanand-bitgo krupanand-bitgo marked this pull request as draft December 12, 2024 14:46
@krupanand-bitgo krupanand-bitgo marked this pull request as ready for review December 12, 2024 16:25
shivpippal
shivpippal previously approved these changes Dec 13, 2024
at31416
at31416 previously approved these changes Dec 13, 2024
shivpippal
shivpippal previously approved these changes Dec 13, 2024
@krupanand-bitgo krupanand-bitgo changed the title feat(statics): enabled bulk withdrawal feature testnet feat(statics): enabled bulk withdrawal feature Dec 16, 2024
@krupanand-bitgo
Copy link
Contributor Author

PR updated:
Had to resolve merged conflicts after rebase.
Changes to pushed to enable BULK_TRANSACTION feature in testnet and production.

@krupanand-bitgo
Copy link
Contributor Author

Approval became stale, resolve merge conflicts

Copy link
Contributor

@ajays97 ajays97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test file changes?

modules/statics/src/coins.ts Outdated Show resolved Hide resolved
modules/statics/src/coins.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, one comment to address about hteth naming.

modules/statics/src/coins.ts Outdated Show resolved Hide resolved
@krupanand-bitgo
Copy link
Contributor Author

No test file changes?

Test Cases added

Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, but have you tested these features for all the coins you modified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants