-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(statics): enabled bulk withdrawal feature #5256
base: master
Are you sure you want to change the base?
Conversation
fcc2e85
to
c42ce77
Compare
c42ce77
to
db51260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests need to be fixed
db51260
to
d7db1a0
Compare
952b906
d7db1a0
to
952b906
Compare
bf951a4
bf951a4
to
37b8b3c
Compare
PR updated: |
37b8b3c
to
9684812
Compare
9684812
to
21de05e
Compare
Approval became stale, resolve merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No test file changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally lgtm, one comment to address about hteth naming.
21de05e
to
ddff08c
Compare
0b3ff41
to
d1d002b
Compare
added test cases Ticket: WIN-3962
d1d002b
to
0542952
Compare
Test Cases added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm, but have you tested these features for all the coins you modified?
Enabled Bulk withdrawal feature in testnet and production for assets mentioned in below ticket.
Ticket: WIN-3962