Merge pull request #5272 from BitGo/BTC-1450.fix-signtx-wallet-param

fix(abstract-utxo): pass actual wallet to signTransaction
BitGo · Dec 15, 2024 · 87a80dc · 87a80dc
2 parents f00ccde + 55caa4a
commit 87a80dc
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 7 deletions.
diff --git a/modules/sdk-coin-hbar/src/hbar.ts b/modules/sdk-coin-hbar/src/hbar.ts
@@ -273,7 +273,6 @@ export class Hbar extends BaseCoin {
    * @param params
    * @param params.txPrebuild {Object} prebuild object returned by platform
    * @param params.prv {String} user prv
-   * @param params.wallet.addressVersion {String} this is the version of the Algorand multisig address generation format
    * @returns Promise<SignedTransaction>
    */
   async signTransaction(params: HbarSignTransactionOptions): Promise<SignedTransaction> {

diff --git a/modules/sdk-coin-trx/src/trx.ts b/modules/sdk-coin-trx/src/trx.ts
@@ -263,7 +263,6 @@ export class Trx extends BaseCoin {
    * @param params
    * @param params.txPrebuild {Object} prebuild object returned by platform
    * @param params.prv {String} user prv
-   * @param params.wallet.addressVersion {String} this is the version of the Algorand multisig address generation format
    * @returns Bluebird<SignedTransaction>
    */
   async signTransaction(params: TronSignTransactionOptions): Promise<SignedTransaction> {

diff --git a/modules/sdk-coin-xtz/src/xtz.ts b/modules/sdk-coin-xtz/src/xtz.ts
@@ -131,7 +131,6 @@ export class Xtz extends BaseCoin {
    * @param params
    * @param params.txPrebuild {Object} prebuild object returned by platform
    * @param params.prv {String} user prv
-   * @param params.wallet.addressVersion {String} this is the version of the Algorand multisig address generation format
    * @returns Bluebird<SignedTransaction>
    */
   async signTransaction(params: Interface.XtzSignTransactionOptions): Promise<SignedTransaction> {

diff --git a/modules/sdk-core/src/bitgo/wallet/wallet.ts b/modules/sdk-core/src/bitgo/wallet/wallet.ts
@@ -2147,10 +2147,7 @@ export class Wallet implements IWallet {
     const signingParams = {
       ...params,
       txPrebuild,
-      wallet: {
-        // this is the version of the multisig address at wallet creation time
-        addressVersion: this._wallet.coinSpecific.addressVersion,
-      },
+      wallet: this,
       keychain: keychains[0],
       backupKeychain: keychains.length > 1 ? keychains[1] : null,
       bitgoKeychain: keychains.length > 2 ? keychains[2] : null,