Merge pull request #5281 from BitGo/BTC-1450.impl-getKeySignatures

feat(abstract-utxo): add getKeySignatures function
BitGo · Dec 16, 2024 · 35fdca6 · 35fdca6
2 parents 29d3d55 + cbbf6e3
commit 35fdca6
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/modules/abstract-utxo/src/keychains.ts b/modules/abstract-utxo/src/keychains.ts
@@ -1,9 +1,10 @@
+import assert from 'assert';
 import * as t from 'io-ts';
 import * as utxolib from '@bitgo/utxo-lib';
 import { IRequestTracer, IWallet, KeyIndices, promiseProps, Triple } from '@bitgo/sdk-core';
 
 import { AbstractUtxoCoin } from './abstractUtxoCoin';
-import assert from 'assert';
+import { UtxoWallet } from './wallet';
 
 /*
 
@@ -64,3 +65,17 @@ export async function fetchKeychains(
   assert(UtxoNamedKeychains.is(result));
   return result;
 }
+
+export const KeySignatures = t.partial({
+  backupPub: t.string,
+  bitgoPub: t.string,
+});
+
+export type KeySignatures = t.TypeOf<typeof KeySignatures>;
+
+export function getKeySignatures(wallet: UtxoWallet): KeySignatures | undefined {
+  if (t.partial({ keySignatures: KeySignatures }).is(wallet._wallet)) {
+    return wallet._wallet.keySignatures;
+  }
+  return undefined;
+}
diff --git a/modules/abstract-utxo/src/transaction/fixedScript/parseTransaction.ts b/modules/abstract-utxo/src/transaction/fixedScript/parseTransaction.ts
@@ -11,7 +11,7 @@ import {
   ParsedTransaction,
   ParseTransactionOptions,
 } from '../../abstractUtxoCoin';
-import { fetchKeychains, toKeychainTriple, UtxoKeychain, UtxoNamedKeychains } from '../../keychains';
+import { fetchKeychains, getKeySignatures, toKeychainTriple, UtxoKeychain, UtxoNamedKeychains } from '../../keychains';
 
 /**
  * @param first
@@ -206,7 +206,7 @@ export async function parseTransaction<TNumber extends bigint | number>(
 
   return {
     keychains,
-    keySignatures: _.get(wallet, '_wallet.keySignatures', {}),
+    keySignatures: getKeySignatures(wallet) ?? {},
     outputs: allOutputDetails,
     missingOutputs,
     explicitExternalOutputs,