Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RESP3 types (Part 1) #55

Merged

Conversation

jonathanl-bq
Copy link

@jonathanl-bq jonathanl-bq commented Jan 10, 2024

This PR adds support for RESP3 types, excluding Attribute, Push, and BigNumber, since these are not supported by other wrappers yet and are trickier to implement.

Each type has a Java unit test to check if Redis Values are marshaled into Java values correctly.

java/client/build.gradle Outdated Show resolved Hide resolved
java/client/build.gradle Outdated Show resolved Hide resolved
java/src/lib.rs Show resolved Hide resolved
java/src/lib.rs Show resolved Hide resolved
java/src/lib.rs Show resolved Hide resolved
java/client/src/test/java/glide/ffi/FfiTest.java Outdated Show resolved Hide resolved
java/client/src/test/java/glide/ffi/FfiTest.java Outdated Show resolved Hide resolved
java/client/src/test/java/glide/ffi/FfiTest.java Outdated Show resolved Hide resolved
java/client/src/test/java/glide/ffi/FfiTest.java Outdated Show resolved Hide resolved
java/client/src/test/java/glide/ffi/FfiTest.java Outdated Show resolved Hide resolved
@Yury-Fridlyand
Copy link

I think we should create a new gradle task for these tests and

  • make new task to execude these tests only (filter)
  • configure the default test to skip them (also filter)
  • add this task as part of build major task or add it to CI

@jonathanl-bq
Copy link
Author

I think we should create a new gradle task for these tests and

* make new task to execude these tests only (filter)

* configure the default `test` to skip them (also filter)

* add this task as part of `build` major task or add it to CI

Do you know how to do this? I'm not familiar enough with Gradle to throw this together quickly. I might just log a separate task for this if you don't.

@Yury-Fridlyand
Copy link

Do you know how to do this? I'm not familiar enough with Gradle to throw this together quickly. I might just log a separate task for this if you don't.

No, but hivemind does.

This works, for example:

test {
    exclude '**/SomeOtherTests.class'
}

tasks.register("ffi", Test) {
    include '**/SomeOtherTests.class'
}

ref: https://mkyong.com/gradle/gradle-how-to-exclude-some-tests/

Feel free to play and learn

java/client/src/test/java/glide/ffi/FfiTest.java Outdated Show resolved Hide resolved
java/client/build.gradle Outdated Show resolved Hide resolved
java/src/lib.rs Outdated Show resolved Hide resolved
java/src/lib.rs Show resolved Hide resolved
java/src/lib.rs Show resolved Hide resolved
java/src/lib.rs Show resolved Hide resolved
java/src/lib.rs Show resolved Hide resolved
java/src/lib.rs Show resolved Hide resolved
@jonathanl-bq jonathanl-bq changed the base branch from main to java/integ_lotjonat_resp3_pt1 January 15, 2024 17:50
Copy link

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanl-bq jonathanl-bq merged commit d9bf353 into java/integ_lotjonat_resp3_pt1 Jan 16, 2024
3 checks passed
@acarbonetto acarbonetto deleted the java/dev_lotjonat_resp3_pt1 branch January 16, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants