-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RESP3 types (Part 1) #55
Add support for RESP3 types (Part 1) #55
Conversation
I think we should create a new gradle task for these tests and
|
Co-authored-by: Yury-Fridlyand <[email protected]>
Do you know how to do this? I'm not familiar enough with Gradle to throw this together quickly. I might just log a separate task for this if you don't. |
No, but hivemind does. This works, for example:
ref: https://mkyong.com/gradle/gradle-how-to-exclude-some-tests/ Feel free to play and learn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds support for RESP3 types, excluding Attribute, Push, and BigNumber, since these are not supported by other wrappers yet and are trickier to implement.
Each type has a Java unit test to check if Redis Values are marshaled into Java values correctly.