Python: add BZPOPMIN and BZPOPMAX commands #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
requested review from
GumpacG,
jonathanl-bq,
Yury-Fridlyand,
acarbonetto and
tjzhang-BQ
aaron-congo
commented
May 7, 2024
| ) -> Optional[List[Union[str, float]]]: | ||
| """ | ||
| Blocks the connection until it removes and returns a member with the highest score from the sorted sets stored | ||
| at the specified keys. The sorted sets are checked in the order they are provided. |
There was a problem hiding this comment.
Note: the "keys" arg is not surrounded with angle quotes for other command docs in this file, so I've followed that pattern here
aaron-congo
changed the title
| await redis_client.bzpopmin(["foo"], 0.5) | ||
|
|
||
| # same-slot requirement | ||
| if isinstance(redis_client, RedisClusterClient): |
There was a problem hiding this comment.
This goes to a separate test case in #226
There was a problem hiding this comment.
Since that PR isn't merged into upstream yet, what should I do in this PR? Remove this part of the test?
There was a problem hiding this comment.
Okay, for now I will keep this in and once the separate test case is merged upstream we can move it there
acarbonetto
reviewed
May 7, 2024
jonathanl-bq
reviewed
May 7, 2024
aaron-congo
force-pushed
the
python/dev_acongo_bzpopmax
branch
from
859cadc to
6298c3d
Compare
aaron-congo
force-pushed
the
python/dev_acongo_bzpopmax
branch
from
6298c3d to
693f0f4
Compare
Yury-Fridlyand
approved these changes
May 8, 2024
jonathanl-bq
approved these changes
May 8, 2024
acarbonetto
approved these changes
May 9, 2024
aaron-congo
added a commit
that referenced
this pull request
May 9, 2024
aaron-congo
added a commit
that referenced
this pull request
May 13, 2024
aaron-congo
added a commit
that referenced
this pull request
May 13, 2024
acarbonetto
pushed a commit
that referenced
this pull request
May 14, 2024
* Python: add BZPOPMIN and BZPOPMAX commands (#266) * Update PR link * PR suggestions * Fix rust
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Python: add BZPOPMIN and BZPOPMAX commands (#266) * Update PR link * PR suggestions * Fix rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZPOPMAXcommand. valkey-io/valkey-glide#1255