Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BGSAVE command. #218

Closed
wants to merge 6 commits into from

Conversation

Yury-Fridlyand
Copy link

@Yury-Fridlyand Yury-Fridlyand commented Apr 13, 2024

https://redis.io/docs/latest/commands/bgsave/

Note: No IT for that command, because:

  1. It may fail randomly with Background save already in progress error
  2. It may affect other tests

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
@acarbonetto acarbonetto self-assigned this Apr 15, 2024
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Copy link
Author

I split implementation into 2 commands (note - different docs) and split IT.
The timing question in IT is still open.

@Yury-Fridlyand Yury-Fridlyand marked this pull request as draft April 24, 2024 17:46
@Yury-Fridlyand
Copy link
Author

Suspended - no desicion on how should we test that and whether GLIDE client needs that command

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand marked this pull request as ready for review April 30, 2024 01:30
@Yury-Fridlyand Yury-Fridlyand marked this pull request as draft May 1, 2024 17:27
@Yury-Fridlyand Yury-Fridlyand deleted the java/dev_yuryf_BGSAVE branch September 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants