Skip to content

Commit

Permalink
Connector limitation documentation (opensearch-project#366)
Browse files Browse the repository at this point in the history
* Added Tableau Connector to OpenSearch SQL

Signed-off-by: Guian Gumpac <[email protected]>

* Added CEILING and FLOOR functions

Signed-off-by: Guian Gumpac <[email protected]>

* Added IFNULL function

Signed-off-by: Guian Gumpac <[email protected]>

* Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null

Signed-off-by: Guian Gumpac <[email protected]>

* Added MIN and MAX for two string arguments

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed return type for MID function redefenitions, part of AOS-202

Signed-off-by: Yury Fridlyand <[email protected]>

* Added CAST functions to convert to int or string as part of AOS-202

Signed-off-by: Yury Fridlyand <[email protected]>

* Added HEXBINX and HEXBINY functions from the templace without any modifications

Signed-off-by: Yury Fridlyand <[email protected]>

* Fixed cast to use the OSSQL type

Signed-off-by: Yury Fridlyand <[email protected]>

* Added parenthesis to avoid opensearch-project/issues/293

Signed-off-by: Yury Fridlyand <[email protected]>

* Modified Timestamp conversion formula

Signed-off-by: Guian Gumpac <[email protected]>

* Added comment to TimestampType

Signed-off-by: Guian Gumpac <[email protected]>

* Updated Company Name accroding to the customer's request

Signed-off-by: Yury Fridlyand <[email protected]>

* Updated Vendor Name as well

Signed-off-by: Yury Fridlyand <[email protected]>

* Added few small changes to simplify connector developing and debugging

Signed-off-by: Yury Fridlyand <[email protected]>

* Typo fix

Signed-off-by: Yury Fridlyand <[email protected]>

* Added a simple test from TDVT: case bool0 from test calcs_data (an expression test)
Some mofidication were made in the test framework to make the output more readable

Signed-off-by: Yury Fridlyand <[email protected]>

* Modified the driver to recognize its support for conversion of types

Signed-off-by: Guian Gumpac <[email protected]>

* Removed changes from a different branch

Signed-off-by: Guian Gumpac <[email protected]>

* Removed changes from a different branch

Signed-off-by: Guian Gumpac <[email protected]>

* Made the connector convert keyword columns to string columns

Signed-off-by: Guian Gumpac <[email protected]>

* Fix requested by PR review

Signed-off-by: Yury Fridlyand <[email protected]>

* Modified integration tests to reflect support for conversion types

Signed-off-by: Guian Gumpac <[email protected]>

* Removed connector changes

Signed-off-by: Guian Gumpac <[email protected]>

* Change values to bitmasks

Signed-off-by: Guian Gumpac <[email protected]>

* Add timestamp as a type for the driver

Signed-off-by: Guian Gumpac <[email protected]>

* Added timestamp to SQLGetTypeInfo for the ODBC Driver

Signed-off-by: Guian Gumpac <[email protected]>

* Reverted some previous changes

Signed-off-by: Guian Gumpac <[email protected]>

* Removed generated test output file

Signed-off-by: Guian Gumpac <[email protected]>

* Renamed SqlOdbcPBIConnector to OpenSearch

Signed-off-by: Guian Gumpac <[email protected]>

* According to AOS-248, we have to build the server address string properly:
- add http[s]:// prefix
- add port
In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling.

Signed-off-by: Yury Fridlyand <[email protected]>

* Added version and disable trace output as per Microsoft's feedback

Signed-off-by: Guian Gumpac <[email protected]>

* Added documentation for the OpenSearch connector

Signed-off-by: Guian Gumpac <[email protected]>

* Renamed connector markdown file to follow naming conventions

Signed-off-by: Guian Gumpac <[email protected]>

* Changed image file extention as it was not being detected by GitHub

Signed-off-by: Guian Gumpac <[email protected]>

* Updating docs according to PR #16 comments.

Signed-off-by: Yury Fridlyand <[email protected]>

* Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request.

Signed-off-by: Yury Fridlyand <[email protected]>

* A typo fix in yml

Signed-off-by: Yury Fridlyand <[email protected]>

* A dummy commit to make GitHub Actions start the desired workflow

Signed-off-by: Yury Fridlyand <[email protected]>

* Workflow fix - pack Tableau ODBC connector instead of JDBC one

Signed-off-by: Yury Fridlyand <[email protected]>

* Fix line endings in the workflow file

Signed-off-by: Yury Fridlyand <[email protected]>

* Another dummy commit to start the desired workflow

Signed-off-by: Yury Fridlyand <[email protected]>

* Fix paths in the GitHub workflow

Signed-off-by: Yury Fridlyand <[email protected]>

* Modified workflow to trigger on changes of itself

Signed-off-by: Yury Fridlyand <[email protected]>

* Path fix for preparation step

Signed-off-by: Yury Fridlyand <[email protected]>

* Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them

Signed-off-by: Yury Fridlyand <[email protected]>

* Renamed PBI connector files

Signed-off-by: Yury Fridlyand <[email protected]>

* Moved Tableau JDBC connector to bi-connectors

Signed-off-by: Yury Fridlyand <[email protected]>

* Added packing Tableau JDBC connector
For all connectors added check for successful packing before publishing

Signed-off-by: Yury Fridlyand <[email protected]>

* Renamed Power BI connector as "OpenSearch Project"

Signed-off-by: Yury Fridlyand <[email protected]>

* Renamed output artifact

Signed-off-by: Yury Fridlyand <[email protected]>

* Update SqlOdbcPBIConnector.pq according to PR review notes

Co-authored-by: Kyle Porter <[email protected]>

* Update SqlOdbcPBIConnector.pq according to PR review notes

Co-authored-by: Kyle Porter <[email protected]>

* Modified code that builds the server string

Signed-off-by: Yury Fridlyand <[email protected]>

* Fixed grammatical errors, added a docs directory, and updated the connection string options image

Signed-off-by: Guian Gumpac <[email protected]>

* Removed md file as it was moved to the docs directory

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed grammatical errors and updated the old power bi support document

Signed-off-by: Guian Gumpac <[email protected]>

* Removed extra line

Signed-off-by: Guian Gumpac <[email protected]>

* Disabled building Tableau ODBC connector, because it is not ready for shipping

Signed-off-by: Yury Fridlyand <[email protected]>

* Updated workflow step description

Signed-off-by: Yury Fridlyand <[email protected]>

* Removed packing ODBC driver for Tableau (re: 4cadfd1).
Removed Tableau ODBC driver source files since the driver is not supposed to be.

Signed-off-by: Yury Fridlyand <[email protected]>

* Updated workflow, because connector source files were renamed after merge

Signed-off-by: Yury Fridlyand <[email protected]>

* Revert "Add GitHub workflow to pack BI connectors"

* Changed string replacement in the main connector file

Signed-off-by: Yury Fridlyand <[email protected]>

* Script was modified according to PR comments

Signed-off-by: Yury Fridlyand <[email protected]>

* Added limitations and issues table to connector markdown file

Signed-off-by: Guian Gumpac <[email protected]>

* Removed Tableau ODBC connector

Signed-off-by: Yury Fridlyand <[email protected]>

* Merged OpenSearch-sql main to this branch and updated links as per the PR comment

Signed-off-by: Guian Gumpac <[email protected]>

* Added link to bug

Signed-off-by: Guian Gumpac <[email protected]>

* Made changes as per requested in the PR comments. Linked github issues to issues listed

Signed-off-by: Guian Gumpac <[email protected]>

* Added changes to the OpenSearch md file

Signed-off-by: Guian Gumpac <[email protected]>

* Removed unused images

Signed-off-by: Guian Gumpac <[email protected]>

Co-authored-by: Yury Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Kyle Porter <[email protected]>
  • Loading branch information
4 people authored Jan 14, 2022
1 parent 1699743 commit 1348b84
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
13 changes: 13 additions & 0 deletions bi-connectors/PowerBIConnector/docs/AmazonOpenSearchService.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,16 @@
2. Check if auth credentials are correct.
3. Check if server is running.

## Limitations and Known issues

There are known limitations and issues that are tracked by OpenSearch including the items listed below.

| Issue | Description |
| ---- | ----------- |
| [Visualizations without numerical columns](https://github.com/opensearch-project/sql/issues/347) | Visualizations is only supported if there is a numerical column included due to a known limitation in OpenSearch regarding subqueries. An exception to this would be visualizations with columns only of type string is supported as well. |
| [Visualizations with First or Last options selected are not yet supported](https://github.com/opensearch-project/sql/issues/279) | First and Last options generate an sql query that uses MAX and MIN for strings which is not yet supported in OpenSearch |
| [Visualizations with aggregate functions selected are not yet supported](https://github.com/opensearch-project/sql/issues/363) | Specifically Minimum, Maximum, Standard deviation, Variance, or Median options are not yet supported. |
| [Basic filtering limitations](https://github.com/opensearch-project/sql/issues/347) | Selecting more than one value is not yet supported when using basic filtering. Due to the issue in the first row of this table, selecting one value for basic filtering when there is no numerical column is not yet supported. |
| [Top N filtering limitations](https://opensearch.org/docs/latest/search-plugins/sql/limitation/) | OpenSearch has limitations on subquery which does not yet support the Top N filtering functionality. |
| [Advanced filtering limitations](https://github.com/opensearch-project/sql/issues/308) | `does not contain` and `does not start with` filters for string columns are not yet supported. All advanced filtering for numerical columns are not yet supported except for `is` and `is blank`. All advanced filtering for date and time columns are not yet supported except for `is blank` and `is not blank`. |
| [Relative Date filtering limitations](https://github.com/opensearch-project/sql/issues/364) | Due to a known timestamp issue in OpenSearch, all relative date filtering is not yet supported. |
13 changes: 13 additions & 0 deletions bi-connectors/PowerBIConnector/docs/OpenSearchProject.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,16 @@
2. Check if auth credentials are correct.
3. Check if server is running.

## Limitations and Known issues

There are known limitations and issues that are tracked by OpenSearch including the items listed below.

| Issue | Description |
| ---- | ----------- |
| [Visualizations without numerical columns](https://github.com/opensearch-project/sql/issues/347) | Visualizations is only supported if there is a numerical column included due to a known limitation in OpenSearch regarding subqueries. An exception to this would be visualizations with columns only of type string is supported as well. |
| [Visualizations with First or Last options selected are not yet supported](https://github.com/opensearch-project/sql/issues/279) | First and Last options generate an sql query that uses MAX and MIN for strings which is not yet supported in OpenSearch |
| [Visualizations with aggregate functions selected are not yet supported](https://github.com/opensearch-project/sql/issues/363) | Specifically Minimum, Maximum, Standard deviation, Variance, or Median options are not yet supported. |
| [Basic filtering limitations](https://github.com/opensearch-project/sql/issues/347) | Selecting more than one value is not yet supported when using basic filtering. Due to the issue in the first row of this table, selecting one value for basic filtering when there is no numerical column is not yet supported. |
| [Top N filtering limitations](https://opensearch.org/docs/latest/search-plugins/sql/limitation/) | OpenSearch has limitations on subquery which does not yet support the Top N filtering functionality. |
| [Advanced filtering limitations](https://github.com/opensearch-project/sql/issues/308) | `does not contain` and `does not start with` filters for string columns are not yet supported. All advanced filtering for numerical columns are not yet supported except for `is` and `is blank`. All advanced filtering for date and time columns are not yet supported except for `is blank` and `is not blank`. |
| [Relative Date filtering limitations](https://github.com/opensearch-project/sql/issues/364) | Due to a known timestamp issue in OpenSearch, all relative date filtering is not yet supported. |

0 comments on commit 1348b84

Please sign in to comment.