-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apacheGH-30622: [GAC-11] Put Timestream ODBC driver into Arrow repository without code style fixes #7
apacheGH-30622: [GAC-11] Put Timestream ODBC driver into Arrow repository without code style fixes #7
Conversation
* fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests
* code uploading * fix cppcheck failure (#1) * fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests * verify signer works fine * fix singer could not find the installer package * change signed installer name * fix linux package wrong name issue * restore signer flag * add .gitignore * remove unneeded files * remove unneeded files * address comments * add version to installer name * remove not needed file
…mation improvement (#4) * fix occasional test failure * document update * add check for credentials leak
* pass driver info to Timestream using user agent * add log for user agent setting
Signed-off-by: forestmvey <[email protected]>
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
dd4a531
to
572a830
Compare
6ccb0f4
to
c70f3cf
Compare
d3b82f0
to
b53be45
Compare
…ODBC driver seed disable integration tests from running. The win-build.yml file is copied from Amazon Timestream ODBC driver code.
Note that rest of lint errors are not solved yet.
* integration tests are disabled. * allow build scripts to be run through `chmod`.
b53be45
to
4ac9ff1
Compare
Ubuntu 20.04 Debug Build Test Results Check
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrated code + auto-generated review comments only.
MacOS Big Sur 11 Debug Build Code Coverage Unit and Integration Test Result
|
on: | ||
push: | ||
paths: | ||
- '.github/workflows/win-build.yml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we want mac-build.yml
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch here. I have created Jira to fix this.
on: | ||
push: | ||
paths: | ||
- '.github/workflows/win-build.yml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linux-build.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in #7 (comment)
on: | ||
push: | ||
paths: | ||
- '.github/workflows/win-build.yml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mac-debug-build.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in #7 (comment)
Rationale for this change
Integration Apache 2.0 licensed AWS Timestream ODBC driver into the Arrow repository.
What changes are included in this PR?
cpp/src/arrow/flight/sql
. This seed (files undercpp/src/arrow/flight/sql/amazon-timestream-odbc-driver/*
) does not need to reviewed because its code has not been changed, with the exception of CMAKE files, which have been modified byarchery lint --cmake-format --fix
..github/workflows/*
.Are these changes tested?
Unit tests for Timestream ODBC driver are preserved. Integration tests are not covered as tests for the driver will be added as functionalities are developed.
Are there any user-facing changes?
No.