[WIP] Localize all commands and refactor most commands #445
Conversation
swiizyy
added
translations
dependencies
swiizyy
changed the title
| Tools = '<:tools_birthdayy:1102222421651623936>', | ||
| } | ||
|
|
||
| export const enum BrandingColors { |
There was a problem hiding this comment.
I would prefer having Constant Variable names in UPPERCASE.
What do you think?
| }); | ||
| } | ||
| } | ||
|
|
||
| export const BirthdayApplicationCommandMentions = { |
There was a problem hiding this comment.
exporting command mentions, is this the correct place to do it and what is the usecase?
src/lib/types/Enums.ts
Outdated
| PostStatsSuccess = 'postStatsSuccess', | ||
| } | ||
|
|
||
| export const enum PermissionLevels { |
There was a problem hiding this comment.
What are your plans for this enum?
src/lib/types/permissions.ts
Outdated
There was a problem hiding this comment.
Shouldnt the functions be seperated from the types?
I mean this file is in a folder called types
| } | ||
| } | ||
|
|
||
| export function floatPromise(promise: Awaitable<unknown>) { |
There was a problem hiding this comment.
What is the usecase of this function and the one underneath? when should and can this be used?
| @RequiresUserPermissions('ManageGuild') | ||
| @RequiresGuildContext() | ||
| @RequiresClientPermissions(defaultClientPermissions) | ||
| @RequiresUserPermissions(defaultUserPermissions) |
There was a problem hiding this comment.
the user needs the manage roles or manage server to be able to use the /birthday test command.
There was a problem hiding this comment.
ah are the permission levels for this?
src/routes/webhook/topgg.ts
Outdated
| @@ -37,7 +43,10 @@ export class UserRoute extends Route { | |||
| private async voteProcess(provider: VoteProvider, userId: string) { | |||
| const providerInfo = this.getProviderInfo(provider); | |||
|
|
|||
| const guild = await getGuildInformation(GuildIDEnum.BIRTHDAYY_HQ); | |||
| const guild = await resolveOnErrorCodesDiscord( | |||
There was a problem hiding this comment.
since this is a secario, that we often will face (fetching discord information) i would suggest creating a seperate function for this.
|
|
swiizyy
requested review from
nikolaischunk
and removed request for
nikolaischunk
No description provided.