Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops imports #390

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Ops imports #390

merged 4 commits into from
Dec 22, 2024

Conversation

YoelShoshan
Copy link
Collaborator

No description provided.

SagiPolaczek
SagiPolaczek approved these changes Dec 22, 2024
View reviewed changes
Copy link
Collaborator

@SagiPolaczek SagiPolaczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking I don't like importing from __init__.py files (:

Anyway, it passes and looks good

@YoelShoshan YoelShoshan merged commit a0c7c51 into master Dec 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagiPolaczek SagiPolaczek SagiPolaczek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoelShoshan @SagiPolaczek