Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new TOKENIZER-TYPE=EXTERNAL_EMBEDDINGS_FROM_DICT #387

Merged
merged 4 commits into from
Dec 15, 2024

Conversation

bensha6757
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Two comments inline.

mosheraboh
mosheraboh previously approved these changes Dec 15, 2024
Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Asked to add a comment inline. Other than that, you can go ahead and merge.

@bensha6757 bensha6757 merged commit f00a714 into master Dec 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants