Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto publish to PyPI, Github release and docs on tag #83

Merged
merged 21 commits into from
Nov 19, 2024

Conversation

multimeric
Copy link
Collaborator

Closes #81, closes #64

@multimeric
Copy link
Collaborator Author

multimeric commented Sep 27, 2024

Hi @pr4deepr, can you please ensure that:

  • There is a secret called TWINE_TOKEN associated with this repo which stores a PyPI token that has push permissions to both napari_lattice and lls_core. Should be configurable here
  • The GITHUB_TOKEN has write permission. Should be configured here

This will give the workflow the permissions to push a release.

@pr4deepr
Copy link
Collaborator

  • There is a secret called TWINE_TOKEN associated with this repo which stores a PyPI token that has push permissions to both napari_lattice and lls_core. Should be configurable here

There is a Twine token for the repo which I've used for automatic deployment to pypi before.

Workflow permissions have: Read and Write permissions enabled.

@multimeric
Copy link
Collaborator Author

Okay great. The only issue is that it might not have permissions to push the lls_core package, because it doesn't exist yet. Anyway, once the other issues are fixed, I'll merge this and we can test out a release. It might not work the first time.

@multimeric multimeric marked this pull request as ready for review September 27, 2024 03:57
@multimeric
Copy link
Collaborator Author

Okay, this looks good. We'll have to merge this and then I'll push some tags directly to the repo in order to run the actual deployment. It probably won't work the first time but that's not a big deal.

@multimeric multimeric requested a review from pr4deepr November 19, 2024 02:33
@pr4deepr
Copy link
Collaborator

Thanks, just checking that updating docs will only trigger a docs specific workflow to update the site??

@multimeric
Copy link
Collaborator Author

Oh yeah true, there's no reason to limit the docs to only building when a new release is made

@multimeric
Copy link
Collaborator Author

Okay, I think this is failing to push the docs just because you haven't granted permissions for pull requests to do that, which is a good practice:
image

So this should work once this is merged.

@pr4deepr
Copy link
Collaborator

Actually, I was looking at this now
seems to be already checked as I have used workflows before in this repo

image

@multimeric multimeric merged commit 3b51137 into BioimageAnalysisCoreWEHI:master Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic doc building Fix release process
2 participants