-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lenient deserialization. #154
base: main
Are you sure you want to change the base?
Conversation
sgdesmet
commented
Jan 2, 2024
- Ignore unknown fields as per Ignore uknown fields? #127
- Deserialize unknown enum values into their default value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and welcome! We are excited to see your first pull request and appreciate your contribution to our project. Our team is reviewing your changes and we will provide feedback as soon as possible. Thank you for taking the time to improve our project and we look forward to working with you!
Prevent webhook deserialization failing when Meta adds a field. Fixes Bindambc#127
cb2eec6
to
66f3be3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
============================================
+ Coverage 86.03% 86.14% +0.11%
- Complexity 512 514 +2
============================================
Files 163 165 +2
Lines 1239 1249 +10
Branches 12 12
============================================
+ Hits 1066 1076 +10
Misses 154 154
Partials 19 19 ☔ View full report in Codecov by Sentry. |