Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust proxy implementation #122

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Conversation

pcomp96
Copy link
Contributor

@pcomp96 pcomp96 commented Sep 5, 2023

  • Removed Objects.requireNonNull(port, "Http Port cannot be null"); because port is a primitive value
  • Move the following snippet of code before of authentication required check
sharedClient = sharedClient.newBuilder()
               .proxySelector(proxySelector)
               .build();

@github-actions github-actions bot added the java Pull requests that update Java code label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (86e38de) 84.35% compared to head (06ba226) 85.95%.

Files Patch % Lines
...sapp/api/utils/proxy/CustomProxyAuthenticator.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #122      +/-   ##
============================================
+ Coverage     84.35%   85.95%   +1.59%     
- Complexity      492      498       +6     
============================================
  Files           159      159              
  Lines          1189     1189              
  Branches         12       12              
============================================
+ Hits           1003     1022      +19     
+ Misses          168      148      -20     
- Partials         18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the tests label Sep 5, 2023
@Bindambc Bindambc self-requested a review January 26, 2024 22:55
@Bindambc Bindambc merged commit 2af564c into Bindambc:main Jan 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants