OV-391: add logic to delete video #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiy4
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
sofiia-trokhymchuk
requested changes
Sep 24, 2024
| if (url) { | ||
| const renderIdMatch = url.match(/renders\/([^/]+)/); | ||
|
|
||
| if (renderIdMatch && renderIdMatch[1]) { |
There was a problem hiding this comment.
Use a descriptive const for renderIdMatch[1] since you use it twice
anton-otroshchenko
approved these changes
Sep 26, 2024
sofiia-trokhymchuk
approved these changes
Sep 26, 2024
sofiia-trokhymchuk
deleted the
task/OV-391-add-logic-to-delete-video
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the logic to delete a rendered video from the Remotion S3 bucket