OV-5: Add jwt token #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefano-lacorazza
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
Closed
7 tasks
|
There were some changes in #17 |
stefano-lacorazza
dismissed stale reviews from nikita-remeslov and anton-otroshchenko
via
c1b02a8
…ting OV-8: protect routing
anton-otroshchenko
previously approved these changes
Aug 29, 2024
Im sorry, I dont understand what I have to do. It tells me OV-5 is up to date with next |
o-nedashkivska
previously approved these changes
Aug 29, 2024
sofiia-trokhymchuk
requested changes
Aug 29, 2024
| @@ -16,8 +16,8 @@ class UserService implements Service { | |||
| this.userRepository = userRepository; | |||
| } | |||
|
|
|||
| public find(): ReturnType<Service['find']> { | |||
| return Promise.resolve(null); | |||
| public async find(userId: string): Promise<UserEntity | null> { | |||
There was a problem hiding this comment.
There is no need to specify userId. If you are working inside of the users bundle it is understandable that find uses user id. REST API principles
Comment on lines
5
to
6
| private SECRET_KEY: Uint8Array; | ||
| private EXPIRATION_TIME: string; |
There was a problem hiding this comment.
We are using camelCase for class fields throughout a project
Co-authored-by: Sofiia Trokhymchuk <[email protected]>
stefano-lacorazza
dismissed stale reviews from o-nedashkivska and anton-otroshchenko
via
c4bcd77
Co-authored-by: Sofiia Trokhymchuk <[email protected]>
sofiia-trokhymchuk
approved these changes
Aug 29, 2024
anton-otroshchenko
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged OV-2-add-sign-in-flow to OV-5-JWT-token to implement 'Return token in response to the sign-in and sign-up'
Created token services with createToken and verifyToken using HS256 algorithm.
Added token to UserSignUpResponseDto and UserSignUpResponseDto