-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #102
Open
johndpope
wants to merge
49
commits into
BigZaphod:master
Choose a base branch
from
johndpope:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fixes #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UILabel now borrows a lot from TTAttributedLabel which allows for attributedText, minimumFontSize and numberOfLines to all work. UITextField now supports a placeholder and attributed placeholder as well as removes some extra padding from the internal text storage
10.6 was having some major issues with layer geometry and flipping. When creating the backing layer for UIKitView and UICustomNSClipView I've not set their geometry flipped flags appropriately.
… separately by the text view itself.
…nd views – Text fields now resize properly with their clip view to avoid vertical scrolling - Text views tracking should be less glitchy
- Correctly determine sizing when limiting number of lines - Vertical aligns centre like iOS - Supports all truncation modes like iOS - Now supports strike through attributes
Sometimes it's only necessary to convert the fonts or colours back and forth.
Fixes for UILabel mostly running on 10.6. Frustratingly CoreText's suggestion size engine is really poor and had to manually tweaked a bit.
iOS has no concept of tabs but on OS X it will serve similar to the return command on iOS in which someone normally switches to the next field.
A size of 37x37 was resulting in heavy blurring. 38x38 is more suitable.
Basically 10.6 sucks totally and needed some extra help to ensure line heights are calculated properly. Added a bunch of checks to ensure no explosions happen on invalid CFType objects.
…ascript One could end in a unrecoverable modal sheet state if the WebView automatically closes the window but does not end the sheet session. This matches iOS behaviour where web views have no control over the window.
UIImage will now attempt to load framework images out of the main app bundle and fallback to UIKit bundle if that fails.
More work trying to get this sizing stuff right
Ditched CTFramesetter's method to suggest a size and implemented a consistent and accurate method of getting line heights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.