(COMPLETE) Itinerary - Review, please :) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given we did this together, and this is an older version of the exercise, would you still like review? |
|
I'll say the exercise looks very well done, I don't have any major comments :) |
BrooklinJazz
reviewed
Oct 7, 2022
| finish = DateTime.new!(~D[2022-04-24], ~T[13:00:00]) | ||
| available_mins = DateTime.diff(finish, start, :minute) | ||
|
|
||
| # 2 INPUT: Keyword List |
There was a problem hiding this comment.
Great problem solving, starting with input and output!
|
Thank you Brook.
Yes, we can close this one!
…On Fri, Oct 7, 2022, at 5:05 PM, Brooklin Myers wrote:
Given we did this together, and this is an older version of the exercise, would you still like review?
—
Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3CCQZ67JCXIUXTKLNNL5H3WCA3Z7ANCNFSM6AAAAAAQ6PIXR4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
BigSpaces
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @BrooklinJazz
I have gone through the Itinerary exercise, though I get errors when running
Utils.feedback(:itinerary, Itinerary)My reasoning for the completion is in a code cell at the bottom of the page. I realsed the "inclusive" nature of the comparison afterwards so I added the <= operator in the solution cell afterwards.
Please feel free to address the review either here or during our pre-instruction time. Whatever format suits best!
Thank you