Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

contains.md #474

Merged
merged 3 commits into from
Feb 18, 2020
Merged

contains.md #474

merged 3 commits into from
Feb 18, 2020

Conversation

eneiss
Copy link
Contributor

@eneiss eneiss commented Feb 5, 2020

Hello!
This is my very first pull request to an open-source project, I hope it will be of some use! 😊
I added the .md file describing the contains function for std::set according to the style guide and to what other contributors have already done.
I am looking forward to your feedback if I have done anything wrong!

I used Coliru online compiler instead of ideone because the latter does not support C++2a yet (contains is a C++20 feature), I hope it is not a problem!
I used Coliru online compiler instead of ideone because the latter does not support C++2a yet (contains is a C++20 feature), I hope it is not a problem!
I reverted my first commit because I edited README.md even though I was not supposed to 😅
@eneiss
Copy link
Contributor Author

eneiss commented Feb 6, 2020

#31

Copy link
Owner

@Bhupesh-V Bhupesh-V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks perfect 👍

This is my very first pull request to an open-source project, I hope it will be of some use!

Congo on your first contribution 🎉 👍 😊

@Bhupesh-V Bhupesh-V merged commit da27549 into Bhupesh-V:master Feb 18, 2020
@eneiss
Copy link
Contributor Author

eneiss commented Feb 18, 2020

Great, thanks a lot 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants