Add #errors to JobResult to make parsing out of error messages easi…

…er for the caller.

lib/active_force/bulk/job_result.rb

@@ -1,21 +1,28 @@
 module ActiveForce
   module Bulk
     class JobResult
-      attr_reader :job, :failed, :successful, :stats
+      attr_reader :job, :failed, :successful, :stats, :errors
 
       def initialize(job:)
         @job = job
         @stats = result_from_job_info
         @failed = failed_results
         @successful = successful_results
+        @errors = errors_from_failed_results
       end
 
       def success?
         failed.blank? && successful.present?
       end
 
       private
-      attr_writer :failed, :successful
+      attr_writer :errors, :failed, :successful
+
+      def errors_from_failed_results
+        return [] if @stats[:number_records_failed].zero? || self.failed.blank?
+
+        self.errors = self.failed.pluck('sf__Error').uniq
+      end
 
       def failed_results
         return [] if @stats[:number_records_failed].zero?

spec/active_force/bulk/job_result_spec.rb

@@ -5,14 +5,14 @@
   let(:job) { instance_double(ActiveForce::Bulk::Job)}
 
   let(:failed_results_response) do
-    Faraday::Response.new(status: 200, response_body: "\"sf__Id\",\"sf__Error\"")
+    Faraday::Response.new(status: 200, response_body: "\"sf__Id\",\"sf__Error\"\n\"45678\",\"Something failed.\"")
   end
 
   let(:successful_results_response) do
     Faraday::Response.new(status: 200, response_body: "\"sf__Id\",\"sf__Error\"\n\"12354\",\"false\"\n")
   end
 
-  let(:info) do
+  let(:successful_info) do
     {"id"=>"22222222222222",
       "operation"=>"update",
       "object"=>"FooBar__c",
@@ -34,38 +34,83 @@
       "apexProcessingTime"=>3}
   end
 
-  let(:job_info_response) do
-    Faraday::Response.new(status: 200, response_body: info)
+  let(:failed_info) do
+    {"id"=>"33333333333333",
+      "operation"=>"update",
+      "object"=>"FooBar__c",
+      "createdById"=>"11111111111111111",
+      "createdDate"=>"2023-09-22T16:39:09.000+0000",
+      "systemModstamp"=>"2023-09-22T16:39:13.000+0000",
+      "state"=>"JobComplete",
+      "concurrencyMode"=>"Parallel",
+      "contentType"=>"CSV",
+      "apiVersion"=>58.0,
+      "jobType"=>"V2Ingest",
+      "lineEnding"=>"LF",
+      "columnDelimiter"=>"COMMA",
+      "numberRecordsProcessed"=>1,
+      "numberRecordsFailed"=>1,
+      "retries"=>0,
+      "totalProcessingTime"=>713,
+      "apiActiveProcessingTime"=>323,
+      "apexProcessingTime"=>3}
+  end
+
+  let(:successful_job_info_response) do
+    Faraday::Response.new(status: 200, response_body: successful_info)
+  end
+
+  let(:failed_job_info_response) do
+    Faraday::Response.new(status: 200, response_body: failed_info)
   end
 
   before do
     allow(job).to receive(:failed_results).and_return(failed_results_response)
     allow(job).to receive(:successful_results).and_return(successful_results_response)
-    allow(job).to receive(:info).and_return(job_info_response)
+    allow(job).to receive(:info).and_return(successful_job_info_response)
   end
 
   describe '::new' do
     it 'uses the passed in job object to pull job info' do
-      expect(subject.stats[:total_processing_time]).to eq info['totalProcessingTime']
-      expect(subject.stats[:number_records_processed]).to eq info['numberRecordsProcessed']
-      expect(subject.stats[:number_records_failed]).to eq info['numberRecordsFailed']
+      expect(subject.stats[:total_processing_time]).to eq successful_info['totalProcessingTime']
+      expect(subject.stats[:number_records_processed]).to eq successful_info['numberRecordsProcessed']
+      expect(subject.stats[:number_records_failed]).to eq successful_info['numberRecordsFailed']
       expect(subject.failed).to be_empty
       expect(subject.successful.size).to eq 1
     end
   end
 
-  describe 'success?' do
+  describe '#success?' do
     context 'when no failed results' do
       it 'returns true' do
         expect(subject.success?).to be true
       end
     end
     context 'when there are failed results' do
+      before do
+        allow(job).to receive(:info).and_return(failed_job_info_response)
+      end
       it 'returns false' do
-        subject.instance_variable_set(:@failed, [1])
         expect(subject.success?).to be false
       end
     end
   end
+
+  describe '#errors' do
+    context 'when there are failed results' do
+      before do
+        allow(job).to receive(:info).and_return(failed_job_info_response)
+      end
+      it 'returns an array of errors' do
+        expect(subject.errors).to eq ['Something failed.']
+      end
+    end
+
+    context 'when there are no failed results' do
+      it 'returns an empty array' do
+        expect(subject.errors).to eq []
+      end
+    end
+  end
 end