Rails 7.1, Ruby 3.1, and Ruby 3.2 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smudge
commented
Oct 6, 2023
| @@ -8,15 +8,24 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ruby: ['2.6', '2.7', '3.0'] | |||
| ruby: ['2.6', '2.7', '3.0', '3.1', '3.2'] | |||
There was a problem hiding this comment.
I'd like to drop Ruby < 3 support in the next major release.
smudge
commented
Oct 6, 2023
| }.not_to raise_error | ||
| end | ||
|
|
||
| it "loads classes even if not in default scope" do | ||
| expect { | ||
| YAML.load(Story.create(scoped: false).to_yaml) | ||
| YAML.load_dj(Story.create(scoped: false).to_yaml) |
There was a problem hiding this comment.
This spec just exists to make sure that ActiveRecords work with the psych ext. The new safe YAML.load in Ruby 3.1 and 3.2 requires extra configuration if you want to (de)serialize custom classes, but instead we can use the patched method that this gem actually uses for the same effect as before.
smudge
commented
Oct 6, 2023
| (" enqueued_at: '2023-01-20T18:52:29Z'\n" if ActiveJob::VERSION::MAJOR >= 6), | ||
| (/ timezone: ?\n/ if ActiveJob::VERSION::MAJOR >= 6), | ||
| (/ enqueued_at: '2023-01-20T18:52:29(\.\d+)?Z'\n/ if ActiveJob::VERSION::MAJOR >= 6), | ||
| (/ scheduled_at: ?\n/ if ActiveJob::VERSION::MAJOR >= 7 && ActiveJob::VERSION::MINOR >= 1), |
There was a problem hiding this comment.
This is all some minor formatting variances introduced in newer Rubies & Rails versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Rails 7.1, Ruby 3.1, and Ruby 3.2 to the build matrix.
The gem already works with these versions, but now they are formally tested. (As such, I bumped the gem by a patch version, to signify that this is the first verified-compatible release.)