Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump flutter/dart min sdk constraints #118

Merged
merged 11 commits into from
Sep 11, 2024
Merged

Conversation

btrautmann
Copy link
Contributor

Description

Bumps minimum version constraint on Flutter/dart to 3.16.0/3.2.0 respectively. Doing this ahead of #115 should resolve the issues seen with the build there.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@btrautmann
Copy link
Contributor Author

btrautmann commented Sep 9, 2024

Blocked by the issue(s) mentioned at #104 and #103, looking into it...

jeroen-meijer
jeroen-meijer previously approved these changes Sep 10, 2024
Copy link
Collaborator

@jeroen-meijer jeroen-meijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, looks good otherwise.

Feel free to request another review whenever you're done adding commits, or merge as-is.

test/src/golden_test_scenario_test.dart Outdated Show resolved Hide resolved
Copy link

@ClaireDavis ClaireDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm

@btrautmann
Copy link
Contributor Author

/no-platform

@btrautmann btrautmann merged commit db0a08a into main Sep 11, 2024
3 checks passed
@btrautmann btrautmann deleted the bt/flutter-3.16.0 branch September 11, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants