-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump flutter/dart min sdk constraints #118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btrautmann
requested review from
samandmoore,
Kirpal,
jeroen-meijer and
marcossevilla
as code owners
September 9, 2024 20:58
jeroen-meijer
previously approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, looks good otherwise.
Feel free to request another review whenever you're done adding commits, or merge as-is.
7 tasks
Co-authored-by: Jeroen Meijer (Jay) <[email protected]>
btrautmann
force-pushed
the
bt/flutter-3.16.0
branch
from
September 10, 2024 18:18
2305cd3
to
d1eddc9
Compare
btrautmann
force-pushed
the
bt/flutter-3.16.0
branch
from
September 10, 2024 18:25
70cb79d
to
0711fe2
Compare
1 task
ClaireDavis
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain lgtm
/no-platform |
Kirpal
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps minimum version constraint on Flutter/dart to 3.16.0/3.2.0 respectively. Doing this ahead of #115 should resolve the issues seen with the build there.
Type of Change