-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: loading fonts from other packages #111
Conversation
This pull request has been automatically closed because it has not been updated in the last month. 😪 If you still need this change, you can reopen it. Thanks for helping keep our house in order! |
Thank you! |
@krispypen mind pushing an empty commit to your branch? We updated CI configuration on our end which seems to have reset the statuses for |
hey @btrautmann I pushed an empty commit, not sure if it's actually triggering something now |
Looks like it worked, we just have one failing test |
Hi everyone, can we get this in, pls? |
@krispypen just needs to patch/address the one failing test |
oh, having a look sorry 🥹 |
I did the change and locally it works, but it looks like someone needs to approve before the test runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain lgtm
platform lgtm
Description
Font rendering did not work when fonts are from another package. We are using a separate package for our styleguide including assets, textstyles and fonts... This change makes it possible.
Type of Change