Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading fonts from other packages #111

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Conversation

krispypen
Copy link
Contributor

Description

Font rendering did not work when fonts are from another package. We are using a separate package for our styleguide including assets, textstyles and fonts... This change makes it possible.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bmt-github-policybot
Copy link

This pull request has been automatically closed because it has not been updated in the last month. 😪

If you still need this change, you can reopen it.

Thanks for helping keep our house in order!

@TimmyChannel
Copy link

Thank you!

@btrautmann
Copy link
Contributor

@krispypen mind pushing an empty commit to your branch? We updated CI configuration on our end which seems to have reset the statuses for build and pana and AFAIK Github UI has no way of kicking these off separately/manually. I'll re-approve upon success and we can get this merged.

@krispypen
Copy link
Contributor Author

hey @btrautmann I pushed an empty commit, not sure if it's actually triggering something now

@btrautmann
Copy link
Contributor

hey @btrautmann I pushed an empty commit, not sure if it's actually triggering something now

Looks like it worked, we just have one failing test

@pedromassango
Copy link
Contributor

Hi everyone, can we get this in, pls?

@btrautmann
Copy link
Contributor

Hi everyone, can we get this in, pls?

@krispypen just needs to patch/address the one failing test

@krispypen
Copy link
Contributor Author

oh, having a look sorry 🥹

@krispypen
Copy link
Contributor Author

I did the change and locally it works, but it looks like someone needs to approve before the test runs.

Copy link
Contributor

@btrautmann btrautmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm
platform lgtm

@btrautmann btrautmann merged commit f21d072 into Betterment:main Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants