Convert BaseShape's endDraw to a function extension

BennyKok · Mar 30, 2021 · 2fad73b · 2fad73b
1 parent c95bf51
commit 2fad73b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/app/src/main/java/com/benny/pxerstudio/shape/BaseShape.kt b/app/src/main/java/com/benny/pxerstudio/shape/BaseShape.kt
@@ -34,13 +34,13 @@ abstract class BaseShape {
         return !hasEnded
     }
 
-    protected fun endDraw(previousPxer: ArrayList<Pxer>, pxerView: PxerView) {
+    protected fun PxerView.endDraw(previousPxer: ArrayList<Pxer>) {
         if (previousPxer.isEmpty()) {
             return
         }
-        pxerView.currentHistory.addAll(previousPxer)
+        this.currentHistory.addAll(previousPxer)
         previousPxer.clear()
-        pxerView.setUnrecordedChanges(true)
-        pxerView.finishAddHistory()
+        this.setUnrecordedChanges(true)
+        this.finishAddHistory()
     }
 }
diff --git a/app/src/main/java/com/benny/pxerstudio/shape/EraserShape.kt b/app/src/main/java/com/benny/pxerstudio/shape/EraserShape.kt
@@ -58,7 +58,7 @@ class EraserShape : BaseShape() {
     override fun onDrawEnd(pxerView: PxerView) {
         super.onDrawEnd(pxerView)
         hasInit = false
-        endDraw(previousPxer, pxerView)
+        pxerView.endDraw(previousPxer)
     }
 
     init {

diff --git a/app/src/main/java/com/benny/pxerstudio/shape/draw/LineShape.kt b/app/src/main/java/com/benny/pxerstudio/shape/draw/LineShape.kt
@@ -68,7 +68,7 @@ class LineShape : DrawShape() {
     override fun onDrawEnd(pxerView: PxerView) {
         super.onDrawEnd(pxerView)
         hasInit = false
-        endDraw(previousPxer, pxerView)
+        pxerView.endDraw(previousPxer)
     }
 
     init {

diff --git a/app/src/main/java/com/benny/pxerstudio/shape/draw/RectShape.kt b/app/src/main/java/com/benny/pxerstudio/shape/draw/RectShape.kt
@@ -49,6 +49,6 @@ class RectShape : DrawShape() {
 
     override fun onDrawEnd(pxerView: PxerView) {
         super.onDrawEnd(pxerView)
-        endDraw(previousPxer, pxerView)
+        pxerView.endDraw(previousPxer)
     }
 }