Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeagueEndpoint update, new properties in championMastery and league #627

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

LeagueEndpoint update, new properties in championMastery and league #627

wants to merge 7 commits into from

Conversation

kwiatkos0
Copy link

@kwiatkos0 kwiatkos0 commented May 9, 2019 •
edited
Loading

#621

#Deprecated

  • GetLeaguePositionsAsync

#Added

  • GetLeagueEntriesAsync
  • GetLeagueEntriesBySummonerIdAsync
  • GetGrandMasterLeagueAsync

#Fixed

  • LeaguePosition.cs
  • ChampionMastery.cs

BenFradet
BenFradet approved these changes May 9, 2019
View reviewed changes
Copy link
Owner

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@BenFradet BenFradet requested a review from JanOuborny May 9, 2019 13:43
@kwiatkos0 kwiatkos0 mentioned this pull request May 9, 2019
Closed
@kirides
Copy link
Contributor

kirides commented May 9, 2019

This kinda makes #622 obsolete

@JanOuborny
Copy link
Contributor

Thanks for your contribution 👍
Unfortunately, we have a merging problem now.
I propose that we merge #622 first, because it contains unit tests for the new methods and closer resembles the structure of the API. When it's done please rebase your branch onto develop and then we are going to merge the remaining changes.

@kwiatkos0
Copy link
Author

Ok, I can also add unit tests and other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenFradet BenFradet BenFradet approved these changes

@JanOuborny JanOuborny Awaiting requested review from JanOuborny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kwiatkos0 @kirides @JanOuborny @BenFradet