fix: filenames with spaces in diff scan #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsapet
force-pushed
the
fix/filenames-with-spaces-in-diff-scan
branch
from
ebe17d7 to
dc78659
Compare
elsapet
force-pushed
the
fix/filenames-with-spaces-in-diff-scan
branch
from
dc78659 to
b7de36c
Compare
elsapet
force-pushed
the
fix/filenames-with-spaces-in-diff-scan
branch
from
b7de36c to
ec1003a
Compare
didroe
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a prefix options to
git diffcommand so we can handle filenames with spaces. Note,git diffputs quotation marks around some whitespace (e.g. tabs) but not single spaces which is the issue we were seeing.Here we use UUID markers for both from and to paths.
Related
Checklist
If this is your first time contributing please sign the CLA